zariiii9003

Results 154 comments of zariiii9003

I see that your library already implements the BusABC API. You could use the [plugin interface](https://python-can.readthedocs.io/en/stable/plugin-interface.html) so your `ZCanBus` can be used via python-can.

@umousesonic did you consider using the [plugin interface](https://python-can.readthedocs.io/en/develop/plugin-interface.html)?

This is obsolete since the socketcan tests run on github actions. Closing.

@danielhrisca merged after only 3.5 years 💪

> If we implement something like this, the API should be close to the builtin [TimedRotatingFileHandler](https://docs.python.org/3/library/logging.handlers.html#timedrotatingfilehandler). But that looks super complicated to be honest. I still think we should create...

I resolved the merge conflicts. There are still a few problems though: - `IXXATBus._send_periodic_internal` must be adapted - IXXATBus and socketcan should warn, if modifier_callback is not None and use...

I think this can be merged if everyone agrees with the changes.

> what's up with checks? I can't see details. it say "The logs for this run have expired and are no longer available." can do it again? hope to help...

Please provide a code example. Using the blocking `time.sleep(0.001)` with asyncio looks wrong to me.

Superseded by #1514