python-can
python-can copied to clipboard
Mf4 io
I rebased https://github.com/hardbyte/python-can/pull/554/
mf4-io can probably be deleted, should this be merged.
Codecov Report
Merging #1289 (e048df9) into develop (4b1acde) will increase coverage by
0.44%
. The diff coverage is83.55%
.
:exclamation: Current head e048df9 differs from pull request most recent head b123e9b. Consider uploading reports for the commit b123e9b to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## develop #1289 +/- ##
===========================================
+ Coverage 65.16% 65.60% +0.44%
===========================================
Files 81 82 +1
Lines 8853 9074 +221
===========================================
+ Hits 5769 5953 +184
- Misses 3084 3121 +37
@driftregion can i force push to this PR? I fixed a few things here. I can open a new PR, too.
@zariiii9003 sure, go ahead.
@danielhrisca would it be possible to stream to a file directly?
Also: i accessed a private attribute to get the current file size, is there a better way to do that?
@danielhrisca would it be possible to stream to a file directly?
The only way to stream
to the file is to use the extend
method, but this is performance bottleneck for high data rates.
Also: i accessed a private attribute to get the current file size, is there a better way to do that? I don't think so. Why do you need that information?
@danielhrisca
The SizedRotatingLogger starts a new file when a give file size is reached. That's why i added the file_size
function to the logger classes.
The BlfWriter compresses and writes data in chunks so maybe that could be possible here too?
@danielhrisca merged after only 3.5 years 💪
It's like a good wine