Zachary Anderson comments

Results 331 comments of


                                            Zachary Anderson

Memory leak on apk build causing error: si_signo=Segmentation fault(11)

cc @a-siva @rmacnak-google for a reliable `gen_snapshot` crasher in `2.19.0-444.1.beta`.

[CP] Safari Clip Fix

The linked PR should be an open PR against the release branch. @itsjustkevin I think to cherry-pick to stable, it should be `flutter-3.2-candidate.5`, right? Not sure whether this should be...

I have made a CP PR here https://github.com/flutter/engine/pull/38154. @ollydixon in the future when requesting a cherry-pick, you should create a PR against the target branch as part of the request....

[CP] Remove ink_sparkle shader compilation from web builds

cp lgtm.

[CP] Remove glitches when scrolling on old Android TV devices

@itsjustkevin This one should be backported to 3.3. I'll make another PR.

[CP] Remove glitches when scrolling on old Android TV devices

Here is the CP to 3.3 https://github.com/flutter/engine/pull/38075

[CP] Remove glitches when scrolling on old Android TV devices

https://github.com/flutter/engine/pull/38075 is ready to land to the 3.3 branch.

Remove use of NullThrownError

@Piinks reviewed https://github.com/flutter/flutter/pull/108915, and maybe has context on why the `// ignore` was removed there. I'm not sure removing the whole case for that error is correct, but I don't...

Remove use of NullThrownError

Does your branch need to be rebased on tip-of-tree?

Strategies for static content rendering performance

Hi @matthew-carroll, I'm curious about how the display list diagnosis was reached. If there was already a discussion going on another github issue or discord thread, would you mind linking...