Zachary Anderson

Results 331 comments of Zachary Anderson

The `--enable-observatory` flag should be made available before it is required. This is so that we can make changes to pass the flag without losing access to the Observatory.

I'm not sure the timeline is achievable, but otherwise the plan sgtm. I also added https://github.com/flutter/devtools/issues/4711 to the tracker.

@bkonyi `--serve-observatory` needs to be a flag that the Engine can pass to `Dart_SetVMFlags`. Is that what your change did?

@bkonyi That sounds plausible to me, but you'd be the expert on where and when the new flag needs to be set in the service isolate code.

A prereq for this is https://github.com/flutter/flutter/issues/145842.

@bkonyi I won't have access to a Windows machine until next week, would you mind just trying to reproduce this using dart:io File directly?

Oh, sorry, I misunderstood the issue. I had thought that the dart:io File was failing to handle both slash directions. We have lots of tests and code written in the...

Hi there, The Flutter team is now maintaining these packages in the [flutter/packages](https://github.com/flutter/packages) repository at [packages/vector_graphics](https://github.com/flutter/packages/tree/main/packages/vector_graphics) and [packages/vector_graphics_compiler](https://github.com/flutter/packages/tree/main/packages/vector_graphics_compiler). We'd appreciate it if you could direct this PR to those locations...

Hi there, The Flutter team is now maintaining these packages in the [flutter/packages](https://github.com/flutter/packages) repository at [packages/vector_graphics](https://github.com/flutter/packages/tree/main/packages/vector_graphics) and [packages/vector_graphics_compiler](https://github.com/flutter/packages/tree/main/packages/vector_graphics_compiler). We'd appreciate it if you could direct this PR to those locations...

The issue was not the lack of owners approval. I think I'm an owner already. The issue was that reverts should not need 2-human approval. The bot should have approved...