Zachary Anderson comments

Results 331 comments of


                                            Zachary Anderson

bot_update step for Linux Android builds increased by ~5 minutes over the past few days

@godofredoc Could you give me a little more context? Swiftshader should be coming from swiftshader.googlesource.com, and is very similar in that respect coming from googlesource.com repos. How is it different?

bot_update step for Linux Android builds increased by ~5 minutes over the past few days

I think nothing under this bug specifically, but it would be good to follow-up with additional alerting to sheriff/gardener when the bot_update step pushes build times out of SLO. Not...

[CP] null check error during gen_l10n

CP lgtm

[Impeller] Different text weight vs Skia

@jonahwilliams Was there also a follow-up PR to retain linear sampling for rotated text? Did that land?

[Impeller] Different text weight vs Skia

Hi folks. We're expecting multiple Impeller text fixes (https://github.com/flutter/flutter/issues/119292, https://github.com/flutter/flutter/issues/119183) to be in the first 3.7 hotfix release. Please stay tuned.

[CP] [Impeller] Make text glyph offsets respect the current transform

cc @chinmaygarde @bdero

Regression in hot reload time

For reference, libflutter.so size benchmarks dropped by ~34KB compressed https://flutter-flutter-perf.skia.org/e/?begin=1674595149&end=1674605497&keys=Xf63b5d41d99b854ab82e0447d650635f&num_commits=50&request_type=1&xbaroffset=33002

[CP] [Impeller] Check the correct stencil coverage when deciding whether to elide a restore

cc @chinmaygarde @bdero for approval

[CP] [Impeller] uniform offsets account for size

cc @jonahwilliams

[CP] Switch builds over to use iOS-16 devices

CP lgtm. In this case, iOS 16 has been out for a long time, and devices all the way back to the 11s we have in the lab will have...