Evan You comments

Results 333 comments of


                                            Evan You

types(defineComponent): Stricter Component Type + helpers

/ecosystem-ci run

fix(reactivity): fix call sequence of ontrigger in effect

Good catch. I made some small adjustments to make the head logic dev-only.

feat(runtime-core): the `computed` supports exception capture

#11286 is already covered by ee0248acc The changes in this PR are plausible, but given that all computed errors can already be captured and the error location can be traced...

fix(reactiviy): fix arrays don't reactive when mutate index

The idea is right, but the fix can be placed in the instrumented `hasOwnProperty` returned by the proxy trap to only perform the string coercion only for `hasOwnProperty`, instead of...

fix(reactivity): avoid error during nested watch stop

21932840e avoids the extra array copy and also avoid unnecessary `remove` call when the effectScope is already stopped.

VueSSRServerPlugin produces a slow-to-parse JSON for large projects

400ms reload during dev seems acceptable for "a fairly large application"... unless you expect your app to be 3~4 times larger than it already is in the future?

explicitly add `@vue/reactivity` as dependency of `@vue/runtime-dom`

Looks like you need to update the lockfile to get CI passing.

fix(compiler-core): shorthand of :is doesn't work in dynamic component

Thanks for the PR - I think it's better to avoid looping over the props twice as `findProp` does support searching for bindings with no expressions. See https://github.com/vuejs/core/commit/04af9504a720c8e6de26c04b1282cf14fa1bcee3 (I reused...

Render error in `processFragment` when NODE_ENV=production

Can confirm the issue is no longer reproducible in the latest playground.

[Bug]: Rolldown cannot treeshake unused branch

Whether "Treeshaking" or dead-code elimination should be handled by the bundler or the minifier is actually a blurry line. Rollup performs some advanced treeshaking because it does not have a...