core icon indicating copy to clipboard operation
core copied to clipboard

feat(runtime-core): the `computed` supports exception capture

Open linzhe141 opened this issue 1 year ago • 1 comments

close #11286

linzhe141 avatar Jul 03 '24 02:07 linzhe141

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 89.6 kB (+253 B) 34.3 kB (+93 B) 30.9 kB (+80 B)
vue.global.prod.js 146 kB (+253 B) 53.7 kB (+86 B) 47.9 kB (+227 B)

Usages

Name Size Gzip Brotli
createApp 51.5 kB (+177 B) 20.2 kB (+54 B) 18.3 kB (+47 B)
createSSRApp 54.9 kB (+177 B) 21.5 kB (+53 B) 19.5 kB (+40 B)
defineCustomElement 53.8 kB (+177 B) 20.9 kB (+52 B) 19 kB (+32 B)
overall 65.2 kB (+172 B) 25.2 kB (+61 B) 22.8 kB (+54 B)

github-actions[bot] avatar Jul 03 '24 02:07 github-actions[bot]

#11286 is already covered by ee0248acc

The changes in this PR are plausible, but given that all computed errors can already be captured and the error location can be traced in the stacktrace, the value in adding a separate flag for computed is less meaningful, so it's better to save the code and overhead of wrapping all the getters and setters.

yyx990803 avatar Jul 17 '24 06:07 yyx990803