Evan You
Evan You
> `import.meta.hot` vs. `import hot from "some-package"` 👍 Getting rid of tool-specific imports is a good idea. I see it's now been updated to get rid of the import +...
> I agree I haven't seen it in practice either and would be fine to leave this behavior undefined for now Would it then make sense to maybe leave them...
I'm actually ok with including them if there are valid use cases, although in this case it seems we can simply skip the `accept` call if exports is not a...
Oh I see, yeah it would require updating the accept data on the server. I think it makes sense to include them then.
Re dependencies whitelist usage: I'm not sure how your implementation goes, but if we are not replacing the accepting module, and not passing the new accepted modules via the callback,...
Yeah, so here's a use case we've had quite often for the whitelist usage (pseudo code based on Vuex usage, but applies to Redux as well for `store.replaceReducer`): ``` js...
> How does this work with event bubbling? If modules/a is the file that's changed, is newA an updated instance but newB is still the same as it was originally?...
So I noticed a few differences while looking at the latest spec, and I propose some slight syntax changes regarding the callback signature. Currently the spec requires accessing the reloaded...
Follow up: based on webpack's implementation and https://github.com/rixo/rollup-plugin-hot - both attaches persisted data on the `hot` object. Is there any particular reason to pass it via a nested property on...
This may come down to personal preference but I don't really see a problem here - `accept` *is* an overloaded function by design (the type inference also works perfectly fine)....