Walt Karas

https://github.com/apache/trafficserver/blob/d18721884615958f151eee084244c506552c6512/src/traffic_server/InkAPI.cc#L1368 What is the point of a mutex, if the application will crash when there is contention for it. If you really want that behavior, you could just use an...

Make sure, when plugins cause a GET request to fail, there is always a response body.

7

Adds Au test with plugin forcing various errors on various hooks, with default body or set body.

Deprecate TSSslSecretGet (not thread safe).

10

The current version is not thread safe because it returns a pointer into a mutex-protected data structure, which may be invalidated by another thread

Au test spawning a blocking thread in a transaction hook continuation.

10

Getting a result from it, without blocking event thread.

Why are we linking libtsutil.a into all the core plugins?

3

https://github.com/apache/trafficserver/blob/33b795f107b13471a6f4dc62da3669d3acf47ca2/cmake/add_atsplugin.cmake#L22 Could we create both libtsutil.a _and_ libtsutil_link_dummy.so, both with the same contents? Link plugins against the dummy, and only liink traffic_server ELF with libtsutil.a? (libtsutil_link_dummy.so would be an installed...

TLS Au tests are kruftily duplicating pem and key files

1

``` wkaras ~/REPOS/TS2/tests/_sandbox O$ find . -name \*.pem -o -name \*.key ./tls_client_cert2_plugin/ts/ssl/server.pem ./tls_client_cert2_plugin/ts/ssl/server.key ./tls_client_cert2_plugin/ts/ssl/combo-signed-foo.pem ./tls_client_cert2_plugin/ts/ssl/signed-foo.pem ./tls_client_cert2_plugin/ts/ssl/signed-foo.key ./tls_client_cert2_plugin/ts/ssl/signed2-foo.pem ./tls_client_cert2_plugin/ts/ssl/signed-bar.pem ./tls_client_cert2_plugin/ts/ssl/signed2-bar.pem ./tls_client_cert2_plugin/ts/ssl/signed-bar.key ./tls_client_cert2_plugin/signer.pem ./tls_client_cert2_plugin/signer2.pem ./tls_client_cert2_plugin/signed-foo.pem ./tls_client_cert2_plugin/signed-foo.key ./tls_client_cert2_plugin/signed2-foo.pem ./tls_client_cert2_plugin/signed2-bar.pem ./tls_client_cert2_plugin/signed-bar.key ./tls_client_cert_plugin/ts/ssl/server.pem ./tls_client_cert_plugin/ts/ssl/server.key ./tls_client_cert_plugin/ts/ssl/signed-foo.pem...

Errors in Diags::set_std_output() ignored, which can result in a crash.

2

I ran a stress test that exhausts the available file descriptors for the traffic_server process. This caused the Diags::stdout_log member of Diags to be set to nullptr by this line:...