trafficserver icon indicating copy to clipboard operation
trafficserver copied to clipboard

Make sure, when plugins cause a GET request to fail, there is always a response body.

Open ywkaras opened this issue 3 years ago • 7 comments

Adds Au test with plugin forcing various errors on various hooks, with default body or set body.

ywkaras avatar Feb 04 '22 02:02 ywkaras

As an alternative to HttpMsgComp.h, Alan proposes https://github.com/SolidWallOfCode/txn_box/blob/master/plugin/include/txn_box/ts_util.h / https://github.com/SolidWallOfCode/txn_box/blob/master/plugin/src/ts_util.cc

ywkaras avatar Feb 08 '22 01:02 ywkaras

[approve ci centos]

ywkaras avatar Feb 09 '22 18:02 ywkaras

Is this an incompatible change? Since plugin which may have generated empty response bodies in some cases will not generate non-empty response bodies?

ywkaras avatar Jun 07 '22 20:06 ywkaras

This pull request has been automatically marked as stale because it has not had recent activity. Marking it stale to flag it for further consideration by the community.

github-actions[bot] avatar Sep 06 '22 02:09 github-actions[bot]

[approve ci autest]

ywkaras avatar Sep 12 '22 23:09 ywkaras

[approve ci autest]

ezelkow1 avatar Sep 12 '22 23:09 ezelkow1

This was an ask from YCPI Prod. But, no point in fixing it if it's going to continue to rot in the Sun.

ywkaras avatar Sep 13 '22 00:09 ywkaras