Change HttpSM.cc from using Debug() to new interface, Dbg().

[ywkaras]

[ywkaras]

[approve ci ubuntu]

[ywkaras]

I marked this for backport to 9.2, since it seems likely there will be later changes to HttpSM.cc that will have to be backported to 9.2.

[maskit]

If we change "ip-allow" to "ip_allow", we should change ones in IPAllow.cc, HttpTransact.cc, and ip_allow.test.py as well.

I marked this for backport to 9.2, since it seems likely there will be later changes to HttpSM.cc that will have to be backported to 9.2.

I understand that would make backporting other changes easy but isn't the change for "ip-allow" technically an incompatible change? I personally don't mind changing debug tag names on a minor release though.

In either case, we should probably make the change for "ip-allow" separately on another PR for change logs and release notes. We can discuss about the incompatibility on the PR, and that would tell whether we can backport this to 9.x.

[ywkaras]

https://github.com/apache/trafficserver/pull/8830 should be merged prior to merging this PR.

[ywkaras]

The Au test run finished successfully, even though it is reported as "pending": https://ci.trafficserver.apache.org/job/Github_Builds/job/autest/968/consoleFull (See the line 'Commit message: "Merge commit '654417e6ab6fce629d50976c71dac90a32a4b348' into HEAD"').

[bneradt]

The Au test run finished successfully, even though it is reported as "pending": https://ci.trafficserver.apache.org/job/Github_Builds/job/autest/968/consoleFull (See the line 'Commit message: "Merge commit '654417e6ab6fce629d50976c71dac90a32a4b348' into HEAD"').

Oh, interesting. I haven't seen that before. Seems like the jenkins message about the passed autest didn't make it back to github. I'll kick off autest again.

[maskit]

I think we should land this on 10-Dev branch if I understand why the branch exists correctly.

[ywkaras]

I thought that 10-Dev was for certain select large features.

[maskit]

It isn't limited to large features. Incompatible changes should not be merged on master.

I thought we agreed that the ip_allow change is incompatible because you unmarked 9.2.

[ywkaras]

There would probably be many merge conflicts in HttpSM.cc every time we merged master to 10-Dev.

In any case, more urgent work has come up, so I must put this aside for now.

[ywkaras]

The practical way to do this is to merge it on master right after release 9.2 comes out (and make sure it's the first commit in any hypothetical 9.3).

[maskit]

Strictly speaking, this change itself is not incompatible, but #8830 is, IMO. The problem (I think) is that #8830 is already on master. #8830 should be reverted on master and the change should be made on 10-Dev first, if we agree on the change is incompatible.

[github-actions[bot]]

This pull request has been automatically marked as stale because it has not had recent activity. Marking it stale to flag it for further consideration by the community.