Yusuke Wada comments

Results 1706 comments of


                                            Yusuke Wada

Type inference drops routes declared before use() when using method chaining

Hi @sushichan044 > I’m investigating this issue, and I found the following puzzling behavior. What is the puzzling behavior? If you want to show the routes of middleware with `showRoutes`,...

fix(build): generate `_routes.json` based on public directory

@akku1139 Can you write a test for this? > When I delete a files/directories from `public/`, they will also be removed from `dist`.

fix(validator): no return in middleware

Hey @hyoban Can you provide a **minimal** code or project to explain your problem?

fix(validator): no return in middleware

Hi @hyoban Thank you for the response. I understand your problem. Actually, I/we designed the handler after the validator returns a response. So, if you don't return anything, it doesn't...

feat(build): add Lambda / Lambda Edge adapter support and corresponding tests

HI @harajune This PR also supports Lambda Edge, but supporting Lambda is duplicated by #268. We want to give priority to PRs for the earliest created. We will wait for...

feat(build): add Lambda / Lambda Edge adapter support and corresponding tests

Hi @harajune ! As [@Mushus commented](https://github.com/honojs/vite-plugins/pull/268#issuecomment-2952091384), we will go with this PR about supporting Lambda / Lambda Edge instead of #268. @Mushus, can you review this? I'll also do it...

installer fails to fetch

This is not an issue about the `honojs/hono` project. I'll transfer this to `honojs/create-hono`.

Support custom query params parsing logic, instead of URLSearchParams

Duplicated to https://github.com/honojs/hono/issues/3667

`Content-Type` header only works with `ctx.body()`

Like this? If you use `c.text(),`, the content type will be inferred as only `text/plain.` But I can't find a good way to throw a type error now. And type...

`Content-Type` header only works with `ctx.body()`

This is the diff (but verbose): ```diff diff --git a/src/context.ts b/src/context.ts index 9c19eff3..50ed2d06 100644 --- a/src/context.ts +++ b/src/context.ts @@ -21,10 +21,9 @@ import type { SimplifyDeepArray, } from './utils/types' -type...