Timothy Yung comments

Results 19 comments of


                                            Timothy Yung

Fix Promise.finally Non-standard behavior

@zpao, React Native still uses `Promise.native.js`. Thoughts on how to migrate to the specification-compliant implementation?

Fix Promise.finally Non-standard behavior

React Native's version of JSC on Android is super old. On iOS, we delegate to iOS. 👎

React Native 0.66 yarn flow throws an error: Cannot resolve name symbol

Have you tried upgrading your project to [flow-bin@^0.161](https://www.npmjs.com/package/flow-bin) (and updating your `[version]` in your `.flowconfig`)?

feat: Add inputMode prop to TextInput component

> Which keyboard should we show on Android when `inputMode="search"`? Doing the same thing as Chrome seems reasonable. So `inputMode="search"` should display the default keyboard.

Adding TextInput prop accessibilityErrorMessage to announce with TalkBack/VoiceOver screenreaders

Thanks for this great feature! Related… when this gets landed, it would be great to also submit a PR to [`@types/react-native`](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/react-native/index.d.ts#L1299) to add the new prop(s).

Remove eslint-plugin-prettier from eslint-config-react-native

Closed by https://github.com/facebook/react-native/commit/727f30bd0b27ff168e6a6556a9ffbc7e42dbb8f0.

Use as a Trigger in HomeKit

I experienced the same problem and ultimately decided to use hardcoded timed triggers. I'm not sure why it doesn't work. Unfortunately, it's difficult to debug since there are no real...

numberOfLines={1} and alignSelf: 'flex-start' when we set this text is break middle of in Android

Is there something about a single line of truncated text that behaves differently from multiple lines of truncated text? Wouldn't we want this same logic to be accounted for in...

Role and item announcement in Flatlist

The `accessibilityCollectionInfo` API introduced here seems reasonable to me. As a naming nit, could this just be named `accessibilityCollection`?

Add `throttleDisappearingFallbacks` Flag

> Isn't it weird that no tests need updated? I assume that's because the feature flag is set to the same value as `alwaysThrottleRetries` for open source configurations.