facebook
Add `throttleDisappearingFallbacks` Flag
Summary
Creates a new throttleDisappearingFallbacks feature flag that gates the changes from https://github.com/facebook/react/pull/26802 (instead of being controlled by alwaysThrottleRetries). The values of this new flag mirror the current values of alwaysThrottleRetries such that there is no behavior difference.
This additional feature flag allows us to incrementally validate the change (arguably bug fix) from https://github.com/facebook/react/pull/26802 independently from alwaysThrottleRetries.
How did you test this change?
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
Comparing: 7959a1dd28a8b0df9c80dc36bb51a4fa25123d3e...2cb6843fa2dbb4bb4f1aa77cc2015809c2226ede
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
| Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |
|---|---|---|---|---|---|---|
| oss-stable/react-dom/cjs/react-dom.production.min.js | = | 176.83 kB | 176.83 kB | = | 54.90 kB | 54.91 kB |
| oss-experimental/react-dom/cjs/react-dom.production.min.js | = | 173.55 kB | 173.55 kB | = | 54.11 kB | 54.11 kB |
| facebook-www/ReactDOM-prod.classic.js | +0.02% | 594.16 kB | 594.27 kB | +0.02% | 104.41 kB | 104.44 kB |
| facebook-www/ReactDOM-prod.modern.js | +0.02% | 577.42 kB | 577.53 kB | +0.02% | 101.45 kB | 101.47 kB |
| test_utils/ReactAllWarnings.js | Deleted | 66.63 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB |
Significant size changes
Includes any change greater than 0.2%:
Expand to show
| Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |
|---|---|---|---|---|---|---|
| test_utils/ReactAllWarnings.js | Deleted | 66.63 kB | 0.00 kB | Deleted | 16.28 kB | 0.00 kB |
Generated by :no_entry_sign: dangerJS against 2cb6843fa2dbb4bb4f1aa77cc2015809c2226ede
Isn't it weird that no tests need updated?
I assume that's because the feature flag is set to the same value as alwaysThrottleRetries for open source configurations.