Yacin Tmimi

wondering if these changes need to be version gated 🤔

First off, thanks for the thoughtful questions and all the linked discussion! > FWIW I don't use github daily, so please point out if there are some technical issues with...

> @ytmimi - what are the next steps here? Are there any actions that I need to take at this point Again, thanks for your work on this. I'm still...

@anforowicz apologies for the delay. I have some reservations based on the case you outlined in [`Sigils At the start of a line`](https://github.com/rust-lang/rustfmt/pull/5423#issuecomment-1175371400), which I also demonstrated in https://github.com/rust-lang/rustfmt/pull/5423#issuecomment-1179599205. I'm...

@anforowicz no worries. I should have some time in the coming week to review this again.

@anforowicz thanks for turning around the feedback so quickly. I haven't looked at the changes yet, but from your description above they seem reasonable. I also wanted to let you...

As mentioned in the [Comments page of the rust reference](https://doc.rust-lang.org/reference/comments.html#examples) we can have nested block comments. For example: ```rust fn main() { let x = 0; /* start of outer...

> I assume that the desired formatting to indent the internal comment by two spaces instead of one That sounds good, but It's tough to say because the [Comment](https://github.com/rust-dev-tools/fmt-rfcs/blob/b208df842cbfa013fe2d3123a96ef2780a4a9950/guide/guide.md#comments) section...

Thanks for the report. Stripping back the example to just the following: ```rust fn f() { { { SomeStruct { a: b, // // This needs two sets of the...

But I can also confirm that with the original example using `wrap_comment=false` the trailing whitespace is removed, and with `wrap_comments=true` the trailing whitespace remains after formatting. Interesting 🤔