Yacin Tmimi
Yacin Tmimi
> if you mess with any other formatting it fails. Could you elaborate a little more on what you types of formatting you tried messing with? > Without the `max_length`...
Alright, I'll try to take a look into this at some point. For now going to link the tracking issues for `doc_comment_code_block_width` #5415
Looks like the "stable" tests are failing because the ignore list can't be set. I'll add the `#[nightly_only_test]` to the relevant tests. ~~Also looks like some issues with windows paths.~~...
Looking at [(i686-pc-windows-gnu, nightly)](https://github.com/rust-lang/rustfmt/runs/5593529504?check_suite_focus=true#logs) logs (but all windows logs should be similar) I added some `println!` macros to help me debug what's going on. I'm scratching my head because the...
> Haven't looked at this in detail but this type of thing often hints at line endings Ahh I didn't even consider that as a possible issue. I'll investigate that!
@calebcartwright you were right. It turns out it was a line ending issue. For the tests that were giving me trouble I decided to pass them the `newline_style=Unix` config option...
Thanks for reaching out. As you correctly note we don't want to break URLs in comments #506. Here are a few other resolved URL issues that demonstrate scenarios where we...
Apologies, I'm not sure what you mean by *expected*. Do you mean what's the process for opening up a PR? You can read the entire contributing guide, but the [Configuration](https://github.com/rust-lang/rustfmt/blob/master/Contributing.md#configuration)...
This totally makes sense. Should we version gate this or do we want to introduce a closure formatting option?
Also, I wonder if we should hold off on this until after #5337 is merged, to see if these changes play well with the proposed `fn_call_layout` option.