Yacin Tmimi

Going to close this as a duplicate of https://github.com/rust-lang/rustfmt/issues/5213 As mentioned above, the underlying issue here is that rustfmt doesn't currently format `let else`. Rules need to be added to...

Is this not a duplicate of #5431?

I don't see `tab_spaces` or `hard_tabs` explicitly mentioned, but the output from both panics seems similar and the comment https://github.com/rust-lang/rustfmt/issues/4968#issuecomment-949461340 leads me to believe that the original open issue and...

If this is a feature request could you update the title of the issue to reflect that

I believe that's intentional. See #2410 and the linked issues, but long story short rustfmt doesn't support formatting repetitions at the moment.

Ahh I didn't see that part of the style guide. Thanks for pointing that out 😄. Fingers crossed making the change is a simple enough fix! I know you're a...

Definitely! Take the time you need to properly review the change and if you determine that there's something I'm overlooking here I'd be happy to tweak the implementation.

Thanks for the first time contribution to rustfmt 🎉 Haven't had a chance to review this yet, but out of curiosity, why is `tests/target/issue-5377` a binary file?

Will rustfmt add/remove semicolons if we start with the following input? ```rust fn must_end_with_semi() { loop { break false; } } fn cannot_end_with_semi() -> bool { loop { break false...

@robertbastian I think we still need more context in order to figure out what's going on. Could you please provide a complete snippet where you're experiencing this problem. Also as...