Yacin Tmimi
Yacin Tmimi
Great! I'll look to do a follow up after work
If you run `rustfmt --config=error_on_unformatted=true` with the following input: ```rust fn main() { let unformatted = { 1} // comment ; builder .configure(cfg_fn1) .configure(cfg_fn2) // .configure(cfg_fn3) ; } ``` You'll...
Thanks for reaching out. I think this is likely related to #4476 #4867
> Could you explain why an existing test had to be modified? Haven't looked at it (nor the input/source file) yet, but that's often an indicator of an issue Here's...
There were three repos that reported diffs: rust-lang/rust, Rocket, and hyper. The rust-lang/rust diff was just reiterating the change I made to the system test in this PR. The Rocket...
Thanks for reaching out. What version of rustfmt are you using? (run `rustfmt --version` to find out). I'm using `rustfmt 1.5.1-nightly (38659ec6 2022-08-18)`, and can't reproduce any issues. Are you...
We actually don't need to to add `tracing = "0.1.36"` to Cargo.toml to reproduce. I understand now that the issue is that we're not formatting the macro at all, and...
I'm not familiar with the `tracing::info_span!` macro, and found some more details on the `%` by reading the [Recorder Fields](https://docs.rs/tracing/latest/tracing/index.html#recording-fields) section of the docs. Looks like `?` is also used...
@laralove143 could you please post the code snippet to help us try and reproduce the issue.
> So currently the only way is to manually split long string? @tkkcc If you're using a nightly rustfmt you can set [`format_strings=true`](https://github.com/rust-lang/rustfmt/blob/master/Configurations.md#format_strings) to allow rustfmt to break long strings...