Yacin Tmimi

Results 492 comments of Yacin Tmimi

I believe this might be a duplicate of #4613

I think the issue is that the [Configurations.md](https://github.com/rust-lang/rustfmt/blob/master/Configurations.md#configuration-file-resolution) is pointing to [dirs v1.0.4](https://docs.rs/dirs/1.0.4/dirs/fn.config_dir.html), but we've since upgraded to [dirs v4.0.0](https://docs.rs/dirs/4.0.0/dirs/fn.config_dir.html). Can you try placing the global config in `$HOME/Library/Application Support`...

For anyone wanting to work on this we just need to update the link in the first paragraph of the [Configurations.md](https://github.com/rust-lang/rustfmt/blob/master/Configurations.md#configuration-file-resolution) to point at the same version as listed in...

For what it's worth this was the PR that bumped the version #5237

@aizpurua23a thanks for the PR! @laralove143 when you have a moment please confirm that placing your config in `$HOME/Library/Application Support` resolves the issue.

@calebcartwright I went ahead and version gated the changes. If we decide that It doesn't need to be version gated it should be easy to revert the 2nd commit.

The `fn_params_layout` rename has not been released yet. It's only available on master. When checking for configuration values for a certain version of rustfmt I'd recommend looking at https://rust-lang.github.io/rustfmt/

@Frytak thanks for reaching out. There's some nuance with the `single_line_if_else_max_width` configuration that's explained pretty well in https://github.com/rust-lang/rustfmt/pull/5509 (not merged yet). **input** running `rustfmt --config=single_line_if_else_max_width=100,version=Two` ```rust fn contains_statements() { if...

This can be closed now that https://github.com/rust-lang/rustfmt/pull/5910 was merged.

@calebcartwright I took another look and I think this is good to go 👍🏼 and could be included in the next release, but I don't mind if we want to...