Yacin Tmimi

The CI is running into the same issue outlined in https://github.com/rust-lang/rustfmt/pull/5384#issuecomment-1154158644

> Additionally, I'm not sure if there's other scenarios/expr variants in the lhs position where this could occur too From what I can tell there are only three [binary operator](https://doc.rust-lang.org/stable/nightly-rustc/rustc_ast/ast/enum.BinOpKind.html)...

I totally understand that this would be a breaking change for those cases where things already work out just fine. I'll continue to explore what options we have to fix...

I think I'd want to hack on this at least through the weekend, and if I can't make any meaningful progress then I'd be happy to close this and revisit...

Alright, I went ahead and moved the fix up to the Binary expression level. I plan on adding a test to cover the `left shift` case and the `greater than...

Thanks for the review and the great example. I'll put some time aside soon to make the updates!

@calebcartwright ready for a re-review on this one (assuming CI passes). I've gone ahead and implemented your suggestions, and to hopefully help with the review I've broken things up into...

> a quick glance at https://github.com/rust-lang/rustfmt/commit/b7b1083f0da6efc11c4298de5dd0417ce1434439 makes me wonder whether that commit may also be changing logic? It certainly seems to be doing more than a direct extraction which was...

Although #4855 deals with a similar issue, it is not currently resolved by this PR since it goes down a different code path that calls `rewrite_last_closure` instead of `rewrite_closure`. I'm...

Interesting! Any implementation would need to play nice with `reorder_impl_items`. **Questions:** Would this be a binary option like `reorder_impl_items`? I imagine users might want to specify their own ordering, so...