Yacin Tmimi
Yacin Tmimi
>I'd like to ensure that the two buckets of changes (new `-s` option for editor/IDE plugins, and the improved option filtering) get released together, but will defer to you on...
## Check-In Just want to give a follow up on the progress so far: 1) We now only accept a single file 2) cargo-fmt exits early if we try to:...
Thinking through conflicting arguments: * This seems odd, but it's harmless: ``cargo run --bin cargo-fmt -- --version -- --version`` * It looks like ``--message-format`` and ``--emit`` conflict, but we're already...
> * we need to ensure that `cargo metadata` is invoked from the location of the provided source file (it wasn't clear to me that's happening) > * Given the...
I see. I wasn't thinking about it that way. In that case it definitely makes more sense to prevent users from passing the ``--manifest-path``. Is it okay to just pass...
@nickbp Thanks so much for taking the time to looking into the ``MetadataCommand``. Your proposal definitely seems like a worthwhile approach to consider for the ``get_target_from_src_file()`` code path, so I'll...
> To be clear I think the -s/--src-file method is great as-is. If anything, if this was later revisited and cargo fmt [file...] later became valid, there would probably still...
Got it! so I imagine we'd need to stabilize `--skip-children` (ref #5024), so that `cargo fmt` could pass that along when formatting with the `--src-file` option. I'll also set aside...
Just opened #5266, which should hopefully address the `ignore` issue more broadly when passing values via stdin. I wrote up that PR after doing some digging into how `rust-analyzer` calls...
@pankdm thanks for the input. It's hard for me to recall why I originally named the options `-s / --src-file` 🤔. I don't see why it couldn't be `-f /...