Yacin Tmimi

Hey @andrewgazelka, thanks for taking the time to work on this PR, and for your first contribution to rustfmt!! Just want to acknowledge that I've seen this and I'll try...

@calebcartwright thanks for pointing that out. When I have a chance to review this PR I'll make sure to take a look at those links!

Thanks again for opening this PR, but going to close this in favor of #5601, which has a simpler implementation

That's totally fine with me! Just let me know if you'd like to see any changes.

Question: Do we also need to support tying back attributes from sub mods defined inside `cfg_if!` calls? Also do you know what module resolution case would lead to `peek_sub_mod` returning...

Ahh I see. Thanks for pointing that out. I think I'd also need to remove the recursive condition mentioned here https://github.com/rust-lang/rustfmt/pull/4284#discussion_r446670368 to prevent idempotency issues. I haven't looked at the...

Yeah that's odd. Just double checking that you're referring to `/web/subspace/subspace/crates/pallet-subspace/src/lib.rs:478:478:101`?

> * the input to the cargo fmt arg should be constrained to a single file; we shouldn't accept an arbitrary number of inputs for each of which we'd have...

Also, when it comes to the edition, if a user does pass ``--edition`` to rustfmt, we want to honor that right? As it currently stands if you run this ``cargo...

> I want to think on this a bit more, but I am currently leaning towards trying to limit rustfmt args on cargo fmt in cases of direct or potential...