Yacin Tmimi

Results 492 comments of Yacin Tmimi

hmmm 🤔 not sure either, but I'm looking into it!

It looks like these are the snippets rustfmt accepts. I took each one and ran rustfmt on it with the `indent_style` config. What I find odd is that both `struct`...

@jmj0502 I opened up a new issue for this odd struct behavior in #5507

> @ytmimi Okok, I'll proceed to remove the examples 👍 To be clear, I'd like to keep the `impl` example since that's what this PR focused on, but we can...

I want to call out that the following compiles and has empty `bound_generic_params` ```rust fn foo(_: T) where for T: std::fmt::Debug { println!("hello"); } #[derive(Debug)] struct A; fn main() {...

Haven't had a chance to review, but I want to encourage you to read the [GitHub docs on linking PRs to issuses](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword#linking-a-pull-request-to-an-issue-using-a-keyword). Basically if you write `Closes #issue-number` on its...

Note: the only change added to the original commit was the addition of doc comments on the struct, to show that we don't wrap relative file paths in other markdown...

Thanks for your work on this! I Also appreciate you linking some relevant issues. I'm planning to get an initial review done in the next few days

> The proposed fix seem to also resolve issue https://github.com/rust-lang/rustfmt/issues/4649. Could we add test cases for the linked issue if these changes help to resolve what's going on there

> Added test cases for the https://github.com/rust-lang/rustfmt/issues/4649#issue-787737841 of https://github.com/rust-lang/rustfmt/issues/4649 with empty where. > >The https://github.com/rust-lang/rustfmt/issues/4649#issuecomment-952310029 in https://github.com/rust-lang/rustfmt/issues/4649 with non-empty where is a different issue and is probably the same issue...