Yacin Tmimi

> As a general philosophy I think libraries should be cautious about writing directly to stdout/stderr buffers, especially in a manner that callers/consumers can't control. This starts to become more...

> Remind me, is this just waiting on me to take another pass or were there still some other changes you had in mind? There are still a few minor...

@calebcartwright Okay, now I think I'm ready for a re-review (assuming all the CI that's running right now passes successfully!). The PR is on the larger side, so no rush...

I like all your suggestions. I moved the exit early / warning logic to ``format_input_inner``, and I added a new ``ErrorKind`` variant. I'm still going to think on the name...

@calebcartwright Two things to note: 1) I plan on adding some additional tests cases to cover the various combinations of ``trailing_comma`` and ``match_block_trailing_comma``. Just wanted to get the PR in...

@calebcartwright Awesome! Yeah, I'd just want to add a few more test cases and see if I can track down any duplicates. I'll make sure to let you know when...

@calebcartwright no rush on this. I know it's been a while since you've last reviewed it. The last time you looked at these changes you said it was ready to...

@jmj0502 Thank you for your second contribution now! I want to let you know that I've seen this but likely won't get around to reviewing it until later next week.

@jmj0502 Don't worry, I haven't forgotten about this, I just haven't had as much time as I'd like for reviews recently. Apologies for the delay and I'll look to provide...

@jmj0502 thanks for looking into this. I have two asks before moving forward 1) Could we update the [Where predicates](https://github.com/rust-lang/rustfmt/blob/master/Configurations.md#where-predicates) section of the [`indent_style`](https://github.com/rust-lang/rustfmt/blob/master/Configurations.md#indent_style) docs in `Configurations.md` to add a...