Yacin Tmimi

Maybe we take inspiration from [`imports_layout`](https://github.com/rust-lang/rustfmt/blob/master/Configurations.md#imports_layout), and keep `Tall` as the default to maintain the old behavior, but add a new `HorizontalVertical` option, which will always force a vertical layout...

Sorry if that was unclear. Do let me know if I'm misunderstanding what you're saying. What I'm suggesting is that we keep `Tall` as is, and we introduce a new...

Okay, I can see where there might have been a disconnect. I've been pitching ideas to keep `Tall` as the default and introduce something else as the "new" behavior that...

Some notes on what's going on in the `Foo` case: When we call `try_overflow_last_item` we calculate the initial tactic on line 496-501 https://github.com/rust-lang/rustfmt/blob/23ef4b7ac476714886582865b39d396d615a3901/src/overflow.rs#L496-L501 because there are line comments `definitive_tactic` returns...

Thanks for taking the time to implement ``Let`` formatting! I think the implementation of ``rewrite_let`` looks good! I do want to make sure that we're not overlooking anything though. Would...

> We can also just not introduce new behavior with regard to wrapping in this PR since the change is easily separable. I think in this case that's probably the...

> we typically only get one shot at introducing the "right" formatting because of the strong desire to avoid introducing breaking formatting changes multiple times. @petrochenkov I think that's the...

@goffrie I asked the same question https://github.com/rust-lang/rustfmt/pull/5203#issuecomment-1077625775 here, and was already told that it's not a viable option https://github.com/rust-lang/rustfmt/pull/5203#issuecomment-1077707041. The main issues is that we still don't know how to...

> * The behavior should be baked into the rustfmt library, and not the responsibility of consumers (e.g. the rustfmt bin, users of the lib, etc.) to insert another call...

I've been doing a little more work on this PR to implement the custom error return type for ``load_config``. and I've run into an issue. I'm not 100% sure if...