Yoel Spotts
Yoel Spotts
Just want to add our voice to the mix. We are having a issue in production caused by this bug. We are going to deploy our own version based on...
@belimawr added unit tests and update documentation
@belimawr thanks for approving! Any ideas about the failing tests? They seem completely unrelated to my changes. Should we try to rerun them?
@andrewkroh I went in the direction you suggested and allowed the date time to be specified in the path. Let me know what you think. I tested it out locally...
Thanks so much @andrewkroh . I have updated both. However, it looks like there is a failing test of some sort which seems unrelated to these changes. I tried to...
hmm. It looks like all the test are failing on windows? Or is that just where the tests run? Is there any way I could repro or try it out...
It is interesting to me that the code: `output_file = "output/packetbeat-"+self.today+".ndjson"` Seems to assume a unix path separator. Not sure if that would cause problems in windows, but it seems...
@andrewkroh good find. Looks like the `fmtstr` code treats backslash as an escape character: https://github.com/elastic/beats/blob/f6343865bf1d7f772443df02fba0370d993e75ec/libbeat/common/fmtstr/formatstring.go#L377 So the path separator in this case gets swallowed. Uggh. Well I see three ways...
> Here's my idea 🤷 : > > https://github.com/yspotts/beats/compare/config-rnd-path...andrewkroh:beats:config-rnd-path?expand=1 Nice! Let me try and adopt that - lets see if all the tests pass Thanks so much for all your...
> Here's my idea 🤷 : > > https://github.com/yspotts/beats/compare/config-rnd-path...andrewkroh:beats:config-rnd-path?expand=1 well, that wont work for the following example: `c:\path\%{+yyyy-MM-dd-mm}` because it will interpret it as escaping the `%`. At that point,...