reactive-rabbit icon indicating copy to clipboard operation
reactive-rabbit copied to clipboard

Published 20 hours ago • verified publisher icon ScalaConsultants

Don't close subscriber if channel is recoverable.

Open pribor opened this issue 8 years ago • 16 comments

I made some changes to make the auto recovery work.

  • Ignore a channel shutdown event if it is a recoverable channel that wasn't shut down by an application.
  • Try to close the channel in handleCancel method.
  • QueuePublisher registers shutdown listeners to QueueSubscription.
  • Simplify QueueSubscription termination.

pribor avatar Jul 13 '16 21:07 pribor

LGTM

mkiedys avatar Jul 17 '16 12:07 mkiedys

What's the status here?

dskrvk avatar Aug 27 '16 18:08 dskrvk

Hi @pribor! Can you rebase?

mkiedys avatar Aug 29 '16 13:08 mkiedys

Done

pribor avatar Sep 07 '16 11:09 pribor

I tried it: killed rabbit, started it again, but my streams didn't resume..

DGolubets avatar Sep 23 '16 13:09 DGolubets

Is there any chance that this PR will be accepted? I tried to run it and seems to streams resuming works correctly.

kerzok avatar Nov 24 '16 14:11 kerzok

It's been a while since this PR is opened, what is the reason for not merging it?

marius-carp avatar Jan 10 '17 14:01 marius-carp

Bump, with the above question.

duketon avatar Feb 13 '17 08:02 duketon

Can someone confirm if this works?

mkiedys avatar Feb 13 '17 11:02 mkiedys

I'm using it in staging environment and it seems to be working.

marius-carp avatar Feb 13 '17 12:02 marius-carp

Hi guys, it works very well ! Is it possible to merge it ? (BTW more than the branch conflict, I was forced to refactor a little bit the code to build it in scala 2.12)

djamelz avatar Mar 01 '17 14:03 djamelz

Hey folks, We are actively using this fix in production. We had to pin to it in order to continue using this library. We would very much appreciate having this PR merged. If we can help in any way please let me know.

muub avatar May 16 '17 22:05 muub

What's the pb with this PR ? @mkiedys ? What should we do to make you accept it ?

guizmaii avatar May 22 '17 15:05 guizmaii

Just want to add our voice to the mix. We are having a issue in production caused by this bug. We are going to deploy our own version based on this PR. Would love to see this PR get merged in the near future! Thanks for a great library!

yspotts avatar Jun 06 '17 13:06 yspotts

The reason why this stayed open so long are:

  • conflicting reviews suggesting this isn't working
  • no tests
  • no clear story how to replicate and verify if it works

I'm looking into this right now.

mkiedys avatar Jun 06 '17 14:06 mkiedys

What's the relationship to https://github.com/ScalaConsultants/reactive-rabbit/pull/64?

dskrvk avatar Jun 20 '18 20:06 dskrvk