yonghong-song

Results 207 comments of yonghong-song

@vincentmli It is still not clear to me which struct definition in BTF is missing. It would be great to know. Note that BTF generated by the llvm compiler with...

I don't have a good solution for the mismatch between dwarf->btf and llvm btf types. You could have one global definition like ``` union __unused_union { struct a a; struct...

The following commit fixed the issue: https://github.com/iovisor/bcc/commit/95c9229ea9f029a1b9e8dcbe86fc67f037c0dfa2 Could you try latest trunk bcc?

> Exception: Failed to attach BPF program b'trace_rw_entry' to kprobe b'xfs_file_read_iter' This is a different issue. What is your kernel version? Could you check whether `xfs_file_read_iter` symbol exists in your...

This means the symbol `xfs_file_read_iter` is not available in the system for xfsslower to attach. Could you check your system config? Maybe you did not have xfs enabled (CONFIG_XFS_FS)?

The code change mostly fine. But since swapout is not implemented in the original code, I guess swapout in general is not that important. You should in the commit message...

Your change looks okay. But could you have a little more details on the commit message, esp. w.r.t. `passing a modified ctx pointer into trace_rq_issue`. Could you show the assembly...

Your change looks okay. But could you have a little more details on the commit message, esp. w.r.t. `passing a modified ctx pointer into trace_rq_issue`. Could you show the assembly...

Yes, this is an opt-in feature. You need to add the function to err-injection framework. Adding a new function to error injection framework is not complicated. See the example patch...