bcc icon indicating copy to clipboard operation
bcc copied to clipboard

libbpf-tools/bitesize: inline trace_rq_issue

Open cobrien7 opened this issue 3 years ago • 2 comments

When running with 5.10 kernel, bitesize fails verification as a result of passing a modified ctx pointer into trace_rq_issue. Forcing the compiler to inline trace_rq_issue fixes the problem.

Signed-off-by: Connor O'Brien [email protected]

cobrien7 avatar May 26 '22 00:05 cobrien7

Your change looks okay. But could you have a little more details on the commit message, esp. w.r.t. passing a modified ctx pointer into trace_rq_issue. Could you show the assembly code and verification failure log so people can see what is the exact problem?

yonghong-song avatar May 26 '22 22:05 yonghong-song

Your change looks okay. But could you have a little more details on the commit message, esp. w.r.t. passing a modified ctx pointer into trace_rq_issue. Could you show the assembly code and verification failure log so people can see what is the exact problem?

yonghong-song avatar May 26 '22 22:05 yonghong-song