YongChul Kwon
YongChul Kwon
38 digit limit is coming from 128 bit integer and Substrait chose the literal to be 128 bit integer. We could extend the maximal precision as optional type argument (not...
Sounds good. This is also aligned with the #850 which explicitly states disregard output nullability.
> If the behavior is different why not just switch left and right when implementing the join? Is there value in maintaining the source left as left? There are multiple...
> I'm pretty lukewarm on this change similar to Weston and David. Output field emit allows join sides to be swapped without impacting any other node in the plan so...
Please let me know what do you think. I want to contribute more to the project! :)
@jacques-n thank you for feedback! > 1. Do you agree that this is about convenience, not expressibility? (E.g. aggregaterel can already express the semantics of cube and rollup.) Yes, I...
Hi @vbarua, > Based on your point about > > > we could simply have a boolean field with_ties then requires immediate SortRel below FetchRel. However, such conditional inter-rel dependency...
Thanks @benbellick for thoughts! Comments are inlined. > I hadn't heard of this `with ties` syntax before, so forgive me if I am misunderstanding. > > _But_, I wonder if...
@vbarua it is binary compatible. Any reason to hold back this change? This is a good cleanup IMO.
Oh... I didn't realize that the enum values actually don't match! :( As @jcamachor said, I still think this is a necessary breaking change to keep things in consistent state.