substrait icon indicating copy to clipboard operation
substrait copied to clipboard

Disallow usage of ? for returnType of functions with MIRROR nullability

Open vbarua opened this issue 5 months ago • 1 comments

When defining the return type of a function with MIRROR nullability, include a ? after the return type is meaningless, as the nullability is entirely determined based on the nullability of the inputs. For example, given a definition like:

  - name: "foo"
    impls:
      - args:
          - name: x
            value: i8
        nullability: MIRROR
        return: string?

the ? at the end of return: string? is meangingless.

vbarua avatar Aug 08 '25 16:08 vbarua

Sounds good. This is also aligned with the #850 which explicitly states disregard output nullability.

yongchul avatar Aug 08 '25 16:08 yongchul