Yolanda-Chen
Yolanda-Chen
@targos Could you help me merge this PL? I seem not authorized and it's already one week passed. Thank you in advance!
The test failure seems unrelated. Not wasm test and not reproducible locally. Rebased and rerun the test.
Rebase again. Could anyone help approve the workflows?
Seems all test passed. I'm still not authorized. Could anyone help merge this PR? Not sure if any other authority is needed. Thanks in advance!
Thanks Marco! Rebased to avoid test failures.
> I would recommend to not rebase, unless there are conflicts to fix: when you rebase, the PR requires a full CI re-run, while we can simply resume the failed...
Added a new commit to disable revec on mac to avoid a bulid failure with clang13 on macOS. Please see failed log at https://ci.nodejs.org/job/node-test-commit-osx/nodes=osx11-x64/61922/consoleFull. The same file compiles on Linux...
> CI: https://ci.nodejs.org/job/node-test-pull-request/63453/ The test failure on _node-test-commit-arm_ seems timeout: > 21:16:03 not ok 4128 parallel/test-stream-readable-unpipe-resume > 21:16:03 --- > 21:16:03 duration_ms: 360064.83100 > 21:16:03 severity: fail > 21:16:03 exitcode:...
Thanks for the new test! Could this get merged now?
Thank you very much! @aduh95