Yoana Rios comments

Results 7 comments of


                                            Yoana Rios

Bugfix FXIOS-4704 [v105] The awesomebar "history-item" ping is not sent

Build is green ![Screen Shot 2022-08-09 at 11 37 03 AM](https://user-images.githubusercontent.com/18538058/183696078-e9293ecf-8e75-477d-9a6e-4929fc51a16b.png)

Homepage is displayed in the same tab as "github.com" after +4 hours

I couldn't reproduce either following the STR, I tried on iPhone and iPad on main and v104 (14880). If you can reproduce still @SimonBasca we might need to sync because...

Edit mode misbehaves after changing device orientation to landscape and back to portrait

@finebel I think you are right the tableview is loosing the edit state so the solution you are proposing is appropriate, you can open a PR for it and tag...

Bugfix [v107] Don't raise keyboard when restoring the homepage after 4hrs of inactivity

Tested on iPad and the keyboard is not being dismissed properly

#9500: Add to Reading List is allowed on non-reader mode pages

@q2r5 I just reviewed and the fix seems to be great, but the variable `readerModeAvailableOrActive` seems to be not used anymore. This is certainly because this PR has been sitting...

#9500: Add to Reading List is allowed on non-reader mode pages

Green build!! ![Screen Shot 2023-02-01 at 9 47 19 AM](https://user-images.githubusercontent.com/18538058/216075270-004db519-a920-4a09-8012-88d62267e4ae.png)

#9500: Add to Reading List is allowed on non-reader mode pages

LGTM, @q2r5 Thank you for your contribution!