firefox-ios
firefox-ios copied to clipboard
#9500: Add to Reading List is allowed on non-reader mode pages
Fixes #9500.
Only check the reader mode state if the MIME type is HTML.
hi @q2r5 ! As always, it's great seeing your contributions 😄
With the suggested changes, it looks like we still get the option to add to reading list. At launch, I saw that it wasn't available. But when you search again, you'll see it.
The option to add to reading list is shown on search result pages because they can be converted to reader mode, both with these changes and on v95 (6631). As I understood it, the issue was for pages not available for reader mode.
I think what you're referring to is #9747 @nishant2718 ? I think those are two different issues, although similar.
This pull request has conflicts when rebasing. Could you fix it @q2r5?
@q2r5 I just reviewed and the fix seems to be great, but the variable readerModeAvailableOrActive
seems to be not used anymore. This is certainly because this PR has been sitting here for too long, but sadly, this means the work doesn't fix the issue anymore. If you kindly make the required changes to make the fix work again I will review it asap. Thank you for your contribution!
Green build!!
LGTM, @q2r5 Thank you for your contribution!