Yaliang Wu

Results 253 comments of Yaliang Wu

@austintlee Find some other places https://github.com/opensearch-project/ml-commons/blob/main/search-processors/src/main/java/org/opensearch/searchpipelines/questionanswering/generative/client/ConversationalMemoryClient.java#L61 ``` CreateConversationResponse response = client .execute(CreateConversationAction.INSTANCE, new CreateConversationRequest(name)) .actionGet(DEFAULT_TIMEOUT_IN_MILLIS); ``` https://github.com/opensearch-project/ml-commons/blob/main/search-processors/src/main/java/org/opensearch/searchpipelines/questionanswering/generative/client/ConversationalMemoryClient.java#L82C13-L82C23 ``` CreateInteractionResponse res = client .execute( CreateInteractionAction.INSTANCE, new CreateInteractionRequest(conversationId, input, promptTemplate, response, origin,...

> I think we can close this? Yes, close this issue. Thanks Austin.

One more point: add blueprint id, so user can just input "cohere_embedding" , rather than copy the whole blue print

new PR https://github.com/opensearch-project/ml-commons/pull/2345 merged, should we close this PR now ?

Confirmed with @austintlee , close this PR now

@manzke Let's discuss on this https://github.com/opensearch-project/ml-commons/issues/1902 ?

> This problem occurs after the Memory index mapping is updated in the refactoring and the "memory_id" field is set to "text" through dynamic mapping. So the term search query...

Add default process function for cohere rerank model https://github.com/opensearch-project/ml-commons/pull/1954

@asfoorial Can you share detail steps to reproduce the issue ?

Thanks @pranavjad, I think you can pick up this one. Seems no one working on it now.