Yaliang Wu

Results 253 comments of Yaliang Wu

> Just to add to all of this.. there is currently a very suitable SLM in onnx format which is Phi-3 (https://huggingface.co/microsoft/Phi-3-mini-128k-instruct-onnx and https://github.com/microsoft/onnxruntime-genai/blob/main/examples/python/phi-3-tutorial.md) It runs at a very decent...

@whittssg The private local ip blocked now for security concern (to block creating connector to bypass security layer to call your local service directly) https://github.com/opensearch-project/ml-commons/blob/main/ml-algorithms/src/main/java/org/opensearch/ml/engine/httpclient/MLHttpClientFactory.java#L76 Will consult with security guys...

Replied on another Github issue https://github.com/opensearch-project/ml-commons/issues/2126#issuecomment-2091036051 > We had a discussion with security guys, they are ok to add a setting for allowing private IP. So user can control whether...

PR https://github.com/opensearch-project/ml-commons/pull/2534

Thanks a lot. Feel free to raise PR for that blueprint

Ping the memory feature builder @Zhangxunmt, Xun Can you help take a look ? For the first one, is this expected ? For second one, I feel it's not easy...

@ramda1234786 To reply your last comment ## Question 1: Create memory API only requires `name`, other fields will be filled automatically. https://opensearch.org/docs/latest/ml-commons-plugin/api/memory-apis/create-memory/ ## Question 3: The `origin` field stores the...

@Zhangxunmt I think we should put `app_type` to the parent message `origin` field. For this case, it will be `rag`. So user can change agent in future, but if they...

Why remove these settings ? If user don't want to use these features, how they disable it?