Ying
Ying
> @yingsu00 I see, thanks. Can you update the comment to add that this is designed to implement partition column change in table format? Sure. Updated the comment to be...
@Yuhta Hi Jimmy, I addressed your other comments, can you please review again? Thank you!
@Yuhta Hi Jimmy, as you suggested, I created another PR https://github.com/facebookincubator/velox/pull/9707 that does not modify the ColumnStats writing, but with a test in ParquetTableScanTest.cpp using a Parquet file from a...
@jaystarshot Can you please rebase?
closing with https://github.com/facebookincubator/velox/pull/9187
The velox/exec/tests/utils/HiveConnectorTestBase.h has the following lines: ``` private: const std::string filePath_; dwio::common::FileFormat fileFormat_{dwio::common::FileFormat::DWRF}; ``` We want to make the file format as an option to support both DWRF and Parquet
@qqibrow Let's use this issue just for adding the new Velox unit tests, and use another separate issue for Presto Parquet reader tests for Velox. I created https://github.com/facebookincubator/velox/issues/8102 for that.
Fixed and closing
https://github.com/prestodb/presto/pull/21960
cc @upbram123