Ying

Results 62 comments of Ying

cc @Yuhta @oerling

@Yuhta @oerling @zzhao0 Can you please review this?

@Yuhta Jimmy I've addressed all comments, will you be able to take another look? Thank you.

@Yuhta Jimmy thanks for importing this PR. Could you tell me what the failures are on the facebook internal tests?

Closing in favor of https://github.com/facebookincubator/velox/pull/3000

@majetideepak I actually made a mistake in describing the issue. There was no failure for this particular case and sorry for the confusion. This issue is mainly for ParquetTpchTest to...

Related issue https://github.com/facebookincubator/velox/issues/2329 I'm working on a fix. Assigning to myself.

This bug is DWRF only and does not affect the correctness. To fix it, it requires some refactoring and needs to be thought over. I will defer the fix to...