velox icon indicating copy to clipboard operation
velox copied to clipboard

Make velox_hive_connector_test file format agnostic

Open yingsu00 opened this issue 11 months ago • 3 comments

Description

The velox_hive_connector_test and IcebergReadTest are on DWRF files only. We need to extract the file format and use it as a parameter so that other file formats are covered.

yingsu00 avatar Mar 20 '24 09:03 yingsu00

@minhancao is going to take a look cc @yingsu00

ethanyzhang avatar May 09 '24 04:05 ethanyzhang

The velox/exec/tests/utils/HiveConnectorTestBase.h has the following lines:

 private:
  const std::string filePath_;
  dwio::common::FileFormat fileFormat_{dwio::common::FileFormat::DWRF};

We want to make the file format as an option to support both DWRF and Parquet

yingsu00 avatar May 13 '24 23:05 yingsu00

@svm1

minhancao avatar Oct 23 '24 21:10 minhancao