Ying
Ying
> Should we restrict batchRow to uint16_t? @Yuhta I'd love to use larger batch size for my benchmarks. I am not sure if encoding the batch number and row numbers...
cc @rschlussel @kaikalur @rongrong @simmend
@tdcmeehan who is in @prestodb/team-velox?
@nmahadevuni Can you address the conflicts please?
One more thing, we don't typically refer to issue number in the commit title. You can mention that in the commit message.
> 4\. LogicalPropertiesImpl @harshjk Thank you for updating the PR. I see that you addressed the Preconditions comment, but didn't try the ones in the list. Are you still able...
@harshjk Will you be able to squash the commits into one? It looks like you're not working on this any more. I'll take over your PR if I don't hear...
Closing in favor of https://github.com/prestodb/presto/pull/18192
As discussed offline, I created https://github.com/facebookincubator/velox/issues/7929. @chliang71 will just add necessary tests to this PR, and will work on https://github.com/facebookincubator/velox/issues/7929 in a separate PR.
@chliang71 Can you please rebase? The Minio server installation was already fixed in trunk.