presto icon indicating copy to clipboard operation
presto copied to clipboard

Published 20 hours ago • verified publisher icon prestodb

Address review comments for constraints optimization

Open nmahadevuni opened this issue 2 years ago • 1 comments

Comments at https://github.com/prestodb/presto/pull/17917#pullrequestreview-1033413711 addressed

== NO RELEASE NOTE ==

nmahadevuni avatar Aug 11 '22 10:08 nmahadevuni

@yingsu00 : Could you please review?

nmahadevuni avatar Aug 11 '22 17:08 nmahadevuni

@nmahadevuni Can you address the conflicts please?

yingsu00 avatar Aug 17 '22 23:08 yingsu00

@yingsu00 : Can you please review? The test native module is taking too long. The change to make the properties immutable needs some fair amount of refactoring. I will open a different PR for that.

nmahadevuni avatar Aug 22 '22 18:08 nmahadevuni

Thanks @rschlussel @yingsu00 . Addressed the comments and updated the PR.

nmahadevuni avatar Aug 30 '22 11:08 nmahadevuni