Chris Thompson

icon location Edmonton, Alberta, Canada icon location Retired. Previously, staff security developer at https://github.com/clio

Results 3 comments of Chris Thompson

Dump load

> I've merged the previous one but this will take a little bit more review - thanks for now though! Rebased off of `main`. If you don't like/want the union,...

AWS::S3::Connection.prepare_path doesn't properly escape plus sign '+' in key

I have anecdotal evidence that & and ' are also not escaped correctly, and therefore the line in connection.rb should actually be: ``` URI.escape(path).gsub('&',CGI.escape('&')).gsub('+',CGI.escape('+')).gsub('\'', CGI.escape('\'')) ```

HTTP SSL Options Error

I suggest changing the line to: http.use_ssl = options[:use_ssl] || options[:port] == 443 (Sorry, tried attaching a patch but github won't format patches properly)