aws-s3 icon indicating copy to clipboard operation
aws-s3 copied to clipboard

HTTP SSL Options Error

Open btab opened this issue 15 years ago • 2 comments

AWS::S3::Connection.create_connection has the following bit of logic...

http.use_ssl = !options[:use_ssl].nil? || options[:port] == 443

:use_ssl => false thus turns SSL on - which is incorrect/unexpected behaviour

btab avatar Aug 11 '09 17:08 btab

Good catch. Silly mistake. Puzzled that that didn't occur to me.

marcel avatar Aug 11 '09 17:08 marcel

I suggest changing the line to: http.use_ssl = options[:use_ssl] || options[:port] == 443

(Sorry, tried attaching a patch but github won't format patches properly)

yegct avatar Mar 15 '11 20:03 yegct