Yudai Takada

Results 105 comments of Yudai Takada

@yui-knk Is there any blocker left for this pull request?

@yui-knk 1. The test case was incorrect. I add commit https://github.com/ruby/lrama/commit/db76b6317eeb78b501b8ceb2d36f46e6f12c5f56 Correctly, specifying a Named Reference for a parameter results in the following error: ``` Failures: 1) Lrama::Parser#parse when parameterizing...

Thanks for working on this. The following commit adds a type definition to the Lexer class, so this PR is closed. - https://github.com/ruby/lrama/commit/e44b6d380b08c064befe642ba27fc76cfd223c65

IMO, since this gem is an RSpec extension, I think it would be better to fundamentally follow RSpec's policies. When looking at RSpec's policies, I found the following discussion. Basically,...

IMO, I am reluctant to add this cop. [Our project goal](https://docs.rubocop.org/rubocop-rspec/#project-goals) is to **enforce the guidelines and best practices outlined in the community RSpec style guide**. Currently, I am skeptical...

Hi, I think many Rails applications would benefit greatly from a type if the Rails gem was given a type. So I want to help with this project. I'm running...

> Anything particular that can be done to make the "CI / Prism" check pass and get that PR merged? @cbliard Could you try git rebase and import the latest...

It might still have been worthwhile to have this cop if it had supported autocorrection, but since it does not support autocorrection, this cop should be deprecated.

Thank you for your feedback on the autocorrect feature. Your points about needing automated fixes and the specific issue you encountered with test descriptions are noted and helpful. However, I'd...