Yudai Takada
Yudai Takada
@Darhazer I'm eagerly awaiting the addition of this cop. Please let me know if there is anything I can do to help.
@pirj @Darhazer Thanks so much for bringing this forward! I'm sorry I said I would help but I haven't done anything 😅.
I see that part of the issue has been corrected by https://github.com/rubocop/rubocop-rspec/pull/1441 .
However, dividing these into two cops seems like a good and I will try to work on it. It would be good if "the test description is just a String"...
> Maybe we should wait for lrama to implement `'\n'?`? I thought `option (...) `might be easier to understand, but '\n'? sounds good. I changed it. > BTW, why changing...
> we only allowed str and dstr nodes instead? For example, description specifies the class to be tested, so I don't think it is just string and dstr. Regex and...
I changed this cop name from UnclearDescription to UndescriptiveLiteralsDescription.
Looks fine: ``` Offenses: /ydah/real-world-rspec/gitlabhq/spec/services/merge_requests/base_service_spec.rb:83:12: C: RSpec/UndescriptiveLiteralsDescription: Description should be descriptive. describe `#create_pipeline_for` do ^^^^^^^^^^^^^^^^^^^^^^ 22772 files inspected, 1 offense detected ```
@pirj Do you have any concerns?
@pirj I'm sorry. It seems that I didn't explain it enough, but the following comment shows that after doing it with real-wolrld-rspec, I was able to see the offense I...