Yudai Takada comments

Results 105 comments of


                                            Yudai Takada

Use user defined parameterizing rules `f_kw(value)`

Conflicts were resolved.

Better assist rspec rails cop users when migrating to 3

> > I'm thinking if it would make sense to add the `renamed` config that this PR removes from `rubocop-rspec` to each of the new gems respectively, or if that...

Better assist rspec rails cop users when migrating to 3

Perhaps the following changes should be implemented in rubocop-capybara, rubocop-factory_bot and rubocop-rspec_rails. ```yaml # example of rubocop-capybara extracted: RSpec/Capybara/*: ~ ``` refs: https://github.com/rubocop/rubocop-rails/commit/ec173904751ece664f000ee8c999fdeaae5ab98c

Better assist rspec rails cop users when migrating to 3

@jeppester Could you squash two commits?

False negative for `RSpec/RepeatedExampleGroupDescription`

Regarding 1, I'm not sure if we can strictly consider them the same. In particular, if user don't specify `--format documentation`, this cop affects only the test code, but the...

Remove .ruby-version file

Probably, but this issue doesn't occur in rubocop/rubocop. I haven't investigated why, but it seems like some kind of countermeasure has been implemented.

Fix value comparison in job context matcher

Thank you for sending the pull request. I think it makes sense. Can you send a complete pull request with test code?

Fix value comparison in job context matcher

The next patch fixes this issue: - https://github.com/wspurgin/rspec-sidekiq/pull/273

Fix value comparison in job context matcher

Thank you for working on this issue!

Fix false negative for `RSpec/RepeatedExampleGroupDescription` cop when include skip/pending

@pirj I think they were more guarded than necessary to prevent false positives below. No other discussion of skip was found in the PR when the cop was created. ```ruby...