Victor LEUNG

Results 51 comments of Victor LEUNG

hum.. I have to say I'm a little lost from the discussion that went deeper than what I can handle. But I tend to agree with a static method within...

I have an implementation for `Cylinder.from_line_radius` (I'm not sure if it is correct): ``` @classmethod def from_line_radius(cls, line, radius): """Construct a cylinder from its width, height and depth. Note that...

`Line.point_from_start(distance)` ``` def point_from_start(self, distance): """A point along the line, at the specified distance from start. Parameters ---------- distance : float The distance from start. Can be negative or larger...

Yea, I'm aware @beverlylytle . In fact the last thing I modified from Line.point(t) . I think my point is to make my 'user' code easier to read with more...

Here I attach a sample of my 'user' code to illustrate what I mean. It is a function that generates boolean geometry for a 4-stage complex screw hole. ![IMG_20210907_152610](https://user-images.githubusercontent.com/1297653/132352933-319edccb-5583-4644-b380-2fe78c6925d8.jpg) ```...

Cool. By the way, I also noticed that in the old days, we have a clickable [source] link from the docs. And that is very useful. Now those are gone....

Same for the `update_tool` function. https://github.com/compas-dev/compas/blob/75d009d9cdbc2309d606a39a8e3de3c6846535d3/src/compas/robots/base_artist/_artist.py#L259-L277 I'm not sure what exactly does the description want to say: - Is there an internal state in the tool object that holds the...

By the way, I got to say, the Polyhedron class is great for what I needed to do. For irregular solid models with planar faces.

I testify it would be beneficial to my project workflow if the units are explicitly saved. Expecially because I serialize my data multiple times passing them between comaps_fab planning, visualization...