Ya-Chen Hsieh

Results 19 comments of Ya-Chen Hsieh

Seems like Percy visual test is failing. Please re-run.

Could you sync and push to rerun the owners check(which also rerun everything tho)?

I have tested on multiple emails and this issue only happens on iOS Gmail.

I am assuming the consent here is the one you implement using `amp-consent`. Did you try blocking `amp-analytics` using https://amp.dev/documentation/components/amp-consent#basic-blocking-behaviors?

Will bring this back to the team. At the same time also feel free to make the changes directly and we will be happy to review!

I suspect this is more of a feature request as we might not be supporting rendering amp-mustache now. The example you shared within playground works because it is on web,...

This also happens in normal AMP pages. Let's exclude the email condition for easier debugging.

It seems like there's no sound at all for the videos at https://www.frame.media/undercovered/silent-deregulator. I tried the mp4 files included in the `amp-video` in first 2 pages: https://d1no4zdj676ab.cloudfront.net/media/stories/silent-deregulator/element/UC_SDR_Slide1.mp4 and https://d1no4zdj676ab.cloudfront.net/media/stories/silent-deregulator/element/UC_SDR_Slide2.mp4, and...

I don't think `` is allowed inside ``. Could you try use `` or specify `src` attribute instead as mentioned in https://amp.dev/documentation/components/amp-video? Also I guess you want to have something...