Yury Bondarenko

Results 71 comments of Yury Bondarenko

There's also a small bug right now that causes `disctitle` to only appear on the first track of each section

Shouldn't be closed; there's still an in-progress PR to try and adress this & in the meantime this issue should stay open to gather more feedback from users

@JOJ0 looks like in both examples the tracks in each disc/section are handled as subtracks. * in the first example the sections are untitled, so the names of the individual...

@JOJ0 IMO this should probably be handled in a separate issue/PR though, as to avoid more scope creep & delays with this one (mostly on me, but still)

Looks like we can use this rule: https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/docs/rules/use-lifecycle-interface.md

@richardmitic looks good! I'll merge as soon as I get the chance to run this "live" again to confirm.

There are a few other style rules used in DSpace Angular that have been deprecated in base ESLint & are now community-supported in `@stylistic/eslint-plugins`: - `indent` - `comma-dangle` - `object-curly-spacing`...

Labeled as low priority since I applied the workaround in #2865 and it's unlikely that we'll have a better solution save for moving to Prettier.

@tdonohue we've noticed the same problem occurs when creating or editing Communities/Collections Since the fix would be almost identical to the one @KoenP wrote for edit+Item, we'd like to expand...

@tdonohue while expanding this behaviour to Communities & Collections we came to the conclusion that we should take some time to refactor how these sorts of "indexed authorizations" are handled...