beets
beets copied to clipboard
beetbox
[fetchart] Add retry with exponential backoff
Description
The iTunes source returns 403 as a basic form of rate limiting. To get around this, we add a retry with exponential backoff to all requests made by _logged_get(). We also include some other generic error codes to retry.
Fixes #3827, which was closed with no fix. Without this change, two different runs of beet fetchart -f will download different sets of album art because the iTunes has art available but will fail some requests with 403.
To Do
- [ ] Documentation. (If you've add a new command-line flag, for example, find the appropriate page under
docs/to describe it.) - [x] Changelog. (Add an entry to
docs/changelog.rstnear the top of the document.) - [ ] Tests. (Encouraged but not strictly required.)
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
![stale[bot] avatar](https://avatars.githubusercontent.com/in/1724?v=4 "Published by a pub.dev verified publisher"){kind=small}
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
@ybnd Rebased on master and removed the contentious method_whitelist/allowed_methods keyword. What do you think?
@richardmitic looks good! I'll merge as soon as I get the chance to run this "live" again to confirm.
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.